Align post update hook and sync script #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
force-pushed
the
wp-posts-table-add-formatting-options
branch
from
562abd2 to
8e3146d
Compare
danyx23
changed the base branch from
wp-posts-table-add-formatting-options
to
wp-posts-sync-wp-blocks
danyx23
force-pushed
the
wp-sync-align-with-post-update-hook
branch
from
9d5fbf7 to
33da95c
Compare
This was referenced Dec 15, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
danyx23
force-pushed
the
wp-posts-sync-wp-blocks
branch
from
b877f73 to
95c42a6
Compare
danyx23
force-pushed
the
wp-sync-align-with-post-update-hook
branch
from
33da95c to
9b6a951
Compare
danyx23
force-pushed
the
wp-posts-sync-wp-blocks
branch
from
95c42a6 to
b00bb24
Compare
danyx23
force-pushed
the
wp-sync-align-with-post-update-hook
branch
from
9b6a951 to
96fe052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wordpress posts sync script (
syncPostsToGrapher.ts) and the update hook (postUpdatedHook.ts) are supposed to do pretty much the same thing, the former in batch mode and the latter for a single post.The two got a bit our of sync though as of late. One issues was that the treatment of reusable blocks (
wp_block) was different - the sync script ignored them but they still came in via the hook. These can be useful (e.g. to migrate the reuseable blocks that store the content below explorers).Another issue was that the formattingOptions were not yet extracted in the update hook.