🎉 Data insights index page #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
requested review from
sophiamersmann
and removed request for
sophiamersmann
ikesau
force-pushed
the
data-insights-feed
branch
from
413fb62 to
3175217
Compare
ikesau
force-pushed
the
data-insights-fe
branch
from
ea6910b to
2c267e6
Compare
Base automatically changed from
data-insights-fe
to
data-insights-feature-branch
December 18, 2023 21:54
✨ default DI page in mockSiteRouter 🎉 data insights index page
ikesau
force-pushed
the
data-insights-feed
branch
from
02dbe5e to
e1ebc11
Compare
ikesau
commented
Dec 18, 2023
| @@ -1383,6 +1383,8 @@ export interface OwidGdocDataInsightContent { | |||
| type: OwidGdocType.DataInsight | |||
| } | |||
|
|
|||
| export const DATA_INSIGHTS_INDEX_PAGE_SIZE = 2 | |||
There was a problem hiding this comment.
This should be 20 but I've made it artificially low while we're testing pagination
sophiamersmann
approved these changes
Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A feed page with some sense of pagination in the mock site router
Will implement the actual pagination tomorrow