Miscellaneous bug fixes for the site #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
misc-site-fixes-december-2023
branch
from
8d427d3 to
45782f3
Compare
sophiamersmann
approved these changes
Dec 11, 2023
Comment on lines
+297
to
+298
| if (parsed[key] === "true") parsed[key] = true | ||
| if (parsed[key] === "false") parsed[key] = false |
There was a problem hiding this comment.
Given that strings are truthy, wouldn't it be safer to treat "true" as true and everything else as false? Or is that handled elsewhere?
There was a problem hiding this comment.
Good point! We'll need a list of keys that we're expecting to be booleans and make sure that ffalse gets flagged. I'll add that on the other side of the admin refactor 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2981 - preview: after (many tags) | after (few tags) | after (many tags mobile)
Changes gdocs to use proper booleans instead of
"true"and"false"strings for front matter. This is obviously how it should have always been but I was a bit rushed 😇 The migration is overkill seeing as this only affects LTPs and none of them have"sidebar-toc": "false"(which would be treated as truthy until the article was republished) but better safe than sorry!Improves the messaging for how the tag slug field works and what it means
Fixes a random prominent link bug I stumbled upon while testing something else
Adds a warning if you're publishing a non-Fragment gdoc if you don't have any tags set.