🎉 add warning if linking to owid.cloud in gdocs #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
owid-cloud-links
branch
from
4323031 to
8509d3e
Compare
marcelgerber
approved these changes
Nov 14, 2023
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that quite a few of these have snuck into our google docs from the wp migration tool.
This PR adds a warning in the preview if one has persisted (I'm going to go through and fix them in any Gdocs I can find)
We could also add this block to
cheerioToSpanif we wanted to prevent publishing any links to owid.cloud ever, but there might be valid cases where we want to do that, so I'm not sure.