-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bake): lightning deploys populate gdoc metadata #2907
Conversation
Thanks for this @marcelgerber ! I got rid of one last snag which is that posts with a new So by correctly populating the before & after objects, and including I tested this by running a local deploy server and trying various permutations:
The bolded case is not ideal behaviour, technically we only need to rebake the article there, but I don't think it's that common a usecase and the simpler we can keep lightning updates, the better IMO 🙂 |
Nice, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to double check my working 😉
Fixes #2906.
❗ I didn't test this in any way yet!
The underlying issue here was that gdoc properties like
linkedDocuments
andimageMetadata
didn't get populated in the lightning deploy code path (bakeGDocPost
).I instead extended
bakeGDocPosts
to optionally take an array of slugs that it should bake, and bake every published gdoc otherwise.✅ In order to reenable lightning deploys, we will also have to revert ab2b183.