chore(deps): update react to 17 #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, with React 17's changes to event delegation, the event handlers that the newly mounted components set up in `componentDidMount` would fire immediately, immediately dismissing the component again
marcelgerber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're a bit late to the party but here we go.
https://legacy.reactjs.org/blog/2020/10/20/react-v17.html
Because of the changes to event delegation, I had to introduce some
e.stopPropagationcalls.These are necessary if:
onClickhandler or something causes a component to be mounteddocument.addEventListener("click", this.onDismiss)handlerIn that case, the new handler would be called immediately using the same event, which is of course not what we would like to happen.