New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller chromeless explorer embeds in articles & a fix for native tables crashing #2892

Merged

ikesau merged 2 commits into master from hide-controls-explorer-embeds

Nov 6, 2023

Member

ikesau commented Nov 3, 2023

Just two small improvements:

Renders explorers at 8 columns if hideControls=true is present in the query string.
Skips parsing native tables if we're not inside a {.table} block.
1. The alternative was turning {.table-rows} into its own component which was a lot of new code and would require a migration for any tables that had already been created.

ikesau added 2 commits

November 3, 2023 14:57


          🎉 make explorers with hidden controls span 8 columns instead of 12

878d4b9


          🐛 fix broken parsing when using inline table without {.table} tags

8688aaf

ikesau requested a review from danyx23

November 3, 2023 16:56

ikesau self-assigned this

danyx23 approved these changes

View reviewed changes

danyx23 approved these changes

View reviewed changes

Contributor

danyx23 left a comment

:)

ikesau merged commit 7499954 into master

20 checks passed

ikesau deleted the hide-controls-explorer-embeds branch

November 6, 2023 15:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet