Reuse grapher checkboxes in site #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
@danyx23 you recently created a |
sophiamersmann
approved these changes
Nov 3, 2023
| onChange: () => any | ||
| label: string | (() => React.ReactNode) |
There was a problem hiding this comment.
out of interest, why is the label a function and not a plain react node?
There was a problem hiding this comment.
thanks @sophiamersmann!
Yes you're right, we don't need the render prop here 👍
mlbrgl
force-pushed
the
checkbox-site
branch
2 times, most recently
from
c9c9dd5 to
895577e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2890, we need a redesigned checkbox.
this PR makes the recently redesigned checkbox available to the site context.
I'm adding the capability to render nodes in addition to strings in the label. This is to cater for links in the label ("list of donors")
there is a global grapher style which takes care of the checkbox hover state. This style is not available in the site context. I chose to add it to the component itself to make it self-contained. There are other places which rely on the global style, and would require a deeper refactor if we wanted to get rid of it. Here is a demo of the problem this fixes:
Screen.Recording.2023-11-02.at.14.08.57.mov