Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new Gdoc type: linear-topic-page #2883

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Nov 1, 2023

Supersedes #2868

  1. Adds a new type to the gdoc type enum that we can use to add custom behaviours for linear topic pages.
  2. Increases the size of headings in linear topic pages to approximate the same hierarchy that they currently have with their super headings.
  3. Adds logic to wrap headings that were originally h1's (i.e. the grey bar section headings) with horizontal rules.

headings LTP example

@ikesau ikesau force-pushed the linear-topic-page-type branch from 596120e to 1feed0f Compare November 2, 2023 21:15
@ikesau ikesau marked this pull request as ready for review November 2, 2023 21:16
@ikesau ikesau force-pushed the linear-topic-page-type branch from 5a59869 to 0e25eab Compare November 6, 2023 17:09
@ikesau ikesau merged commit a0aefaf into master Nov 6, 2023
13 checks passed
@ikesau ikesau deleted the linear-topic-page-type branch November 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant