Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add indicator shortName to catalogPath in variables table #2845

Merged
merged 1 commit into from
Oct 27, 2023
Merged

✨ add indicator shortName to catalogPath in variables table #2845

merged 1 commit into from
Oct 27, 2023

Conversation

Marigold
Copy link
Contributor

Implementation of owid/etl#1823

  • Append #indicator_short_name to catalogPath
  • Add unique index on catalogPath

@Marigold Marigold requested a review from danyx23 October 25, 2023 07:36
@Marigold Marigold force-pushed the catalogpath-indicator-name-fragment branch from c34db61 to 660d56b Compare October 25, 2023 07:37
@Marigold
Copy link
Contributor Author

@danyx23 would you mind reviewing this, please? The ETL side has been already merged.

danyx23
danyx23 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@Marigold Marigold merged commit bb6300d into master Oct 27, 2023
13 checks passed
@Marigold Marigold deleted the catalogpath-indicator-name-fragment branch October 27, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyx23 danyx23 danyx23 approved these changes

Assignees

@Marigold Marigold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marigold @danyx23