Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 don't leave buildkite hanging for skipped builds #2844

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

Marigold
Copy link
Contributor

@Marigold Marigold commented Oct 24, 2023

Skipped builds (that happen when there's more than one build in the queue) were in an infinite loop, which eventually led to connection timeouts for those old builds. This PR adds all build states and handles them appropriately.

Additionally:

  • await buildkite builds
  • put back local bake when not baking on buildkite (enables baking on staging servers and local)

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC there are 11 states and you check for 8 explicitly in the code - i.e. you throw an error if it is failed, not_run or blocked. I think it would be good to spell that out in a comment, maybe towards the end where you throw the error?

@Marigold
Copy link
Contributor Author

@danyx23 good point, added a comment. I've also fixed two more bugs when testing this on staging:

  • await buildkite builds
  • put back local bake when not baking on buildkite (enables baking on staging servers and local)

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I haven't run it, only read the code. If you want me to try it out please say so but otherwise I think this could be merged

@Marigold Marigold merged commit 3439dd5 into master Oct 24, 2023
13 checks passed
@Marigold Marigold deleted the fix-buildkite-trigger branch October 24, 2023 16:36
@marcelgerber marcelgerber changed the title 🐛 don't leave buildkite handing for skipped builds 🐛 don't leave buildkite hanging for skipped builds Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants