enhance(grapher): disable action on line label click for mobile #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sophiamersmann
commented
Oct 19, 2023
sophiamersmann
commented
- We had a report that the entity selector opened for no apparent reason when clicking on the year button in the timeline
- My guess is that the year button was close to a line label that opens the entity selector on click
- Since the chart area space and the label itself are so small on mobile, we decided to disable opening the entity selector from the line label
sophiamersmann
force-pushed
the
fix-mobile-no-action-on-line-click
branch
from
70be1d1 to
c32db33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.