Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grapher redesign updates (vii) #2759

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Grapher redesign updates (vii) #2759

merged 3 commits into from
Oct 12, 2023

Conversation

samizdatco
Copy link
Contributor

@samizdatco samizdatco commented Oct 12, 2023 •
edited
Loading

Some final(?) tweaks:

  • detect when the page is an embed rendering inside an iframe and use the pop-up settings menu
    • use the isEmbeddedInAnOwidPage flag to detect entries in Related Charts blocks rather than walking the DOM
  • add a shortcut to dismiss an open menu/drawer with the escape key

@samizdatco
🔨 detect internally embedded charts directly
426097a 
- rely on grapher's `isEmbeddedInAnOwidPage` flag rather than searching for a parent element with a class name known to contain Related Charts
@samizdatco samizdatco merged commit 0a6c0ab into grapher-redesign Oct 12, 2023
8 of 10 checks passed
@samizdatco samizdatco deleted the grapher-redesign-updates-cds-7 branch October 12, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samizdatco samizdatco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samizdatco