enhance(admin): persist entities when changing the chart type #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiamersmann
commented
Oct 5, 2023
| if (entity) selection.setSelectedEntities([entity]) | ||
| // non-stacked charts with multiple y-dimensions should select a single entity by default. | ||
| // if possible, the currently selected entity is persisted, otherwise "World" is preferred | ||
| if (selection.numSelectedEntities !== 1) { |
There was a problem hiding this comment.
We could also pick the first entity if multiple entities are currently selected
sophiamersmann
commented
Oct 5, 2023
adminSiteClient/EditorBasicTab.tsx
Outdated
| ) | ||
| // stacked charts or charts with a single y-dimension should select multiple entities by default. | ||
| // if possible, the currently selected entities are persisted, otherwise a random sample is selected | ||
| if (selection.numSelectedEntities === 0) { |
There was a problem hiding this comment.
What if the numSelectedEntities is 1? I've chosen to persist it but we could also sample additional entities...
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
sophiamersmann
force-pushed
the
fix-admin-persist-entitties
branch
from
50341f2 to
a5d47b3
Compare
|
it's a low risk change, so I'll just merge this in now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution