🐛 tighten gdoc regex to not match on sheets links #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
fix-docs-sheets-regex
branch
from
1805f25 to
3f670a7
Compare
marcelgerber
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RegEx was catching a spreadsheet link Hannah had included in the article on deforestation and causing Gdoc validation to complain about linking to an article that hadn't been registered.
This PR updates the RegEx to require the
/document/resource be specified, and uses a more specific non-capturing group to handle the optional google account information that may be contained in the link.To test, I extracted all the docs.google.com URLs we have in prod and ran them on regex101.com. The spreadsheet URL was the only one that didn't match.
And here is the link working correctly now: