Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grapher redesign: Add feedback for empty search result in entity selector #2675

Merged

Conversation

sophiamersmann
Copy link
Member

Add feedback message when no entities could be found on search in the entity selector modal.

  • The message is: Nothing turned up. You may want to try using different keywords or checking for typos."
  • A more specific message is displayed when the search input is an actual country (and the entities are country-like): There is no data for the country, region or group you are looking for.

@sophiamersmann sophiamersmann changed the title feat(grapher): add feedback when no entities could be found Grapher redesign: Add feedback for empty search result in entity selector Sep 29, 2023
@sophiamersmann sophiamersmann merged commit acae113 into grapher-redesign Sep 29, 2023
11 of 14 checks passed
@sophiamersmann sophiamersmann deleted the grapher-redesign-entity-selector-empty-state branch September 29, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant