New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explorer): fix data loading issue in mixed-content explorers #2665

Merged

sophiamersmann merged 1 commit into master from fix-data-loading-issue-in-explorers

Sep 26, 2023

Member

sophiamersmann commented Sep 26, 2023 •

edited

Loading

Fixes a data loading issue that only happens for mixed-content explorers that use grapher IDs as well as csv data to create charts.

for csv data charts, grapher.manuallyProvidedData is true
when switching to a grapher id chart, grapher.manuallyProvidedData was persisted
as a result, no data would be downloaded for the chart (since grapher thinks the data is manually provided)


          fix(explorer): fix data loading issue in mixed-content explorers

233117e

github-actions bot assigned sophiamersmann

sophiamersmann merged commit 14ef2b0 into master

17 checks passed

sophiamersmann deleted the fix-data-loading-issue-in-explorers branch

September 26, 2023 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet