Entry Emulator - Edit Notice #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
approved these changes
Oct 3, 2023
ikesau
commented
Oct 4, 2023
db/model/Gdoc/htmlToEnriched.ts
Outdated
| // Special handling for a unique span that we use to mark the first published date | ||
| if ( | ||
| span.spanType === "span-simple-text" && | ||
| span.text.trim().match(/published/) |
There was a problem hiding this comment.
This is probably too generous now and I should make sure it only applies to the first span in the article, not any span that contains the word "published"
ikesau
force-pushed
the
entry-emulator-edit-notice
branch
from
a5d9ddb to
9d26298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our entries and articles have notices at the beginning saying when they were first published and last updated.
In our old articles, these sentences were lifted into the article header, but the wp migration was putting them unceremoniously into the article body.
This PR adds code which identifies these phrases and puts them in a callout.
Before
After