Entry Emulator - Stacked Columns #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
reviewed
Oct 3, 2023
There was a problem hiding this comment.
I'm fine with this technically but are we sure we want this in general? cc @JoeHasell
|
Thanks @danyx23 – I don't have a sense of what the PR is actually implementing. Going purely off Ike's framing at the top, I agree it's too general compared with what we had in mind. See my thread here in Slack in reply to Ike a few days back. |
…nsolidate columns for linear entries only
ikesau
force-pushed
the
entry-emulator-columns
branch
from
e4c47b1 to
6744d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Joe, the authors want to move away from two-column layouts in general, because it results in writing that doesn't work well on mobile where we always have to be single column anyway.
Running this on all our posts will require quite a bit of manual touching up for all the times where a column starts with "In this chart we can see...." and then, now at the bottom of several paragraphs, the chart will finally be visible.
So even though this is a fairly rudimentary solution, my thinking is that we get this merged now, and then the leads can see how it looks during their session on Tuesday and determine if they want to prioritize a more intelligent column consolidation algorithm, or if there's something else they'd prefer I work on because they're fine with doing the touchups manually.
Before
After