Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various small site bugfixes #2637

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Various small site bugfixes #2637

merged 5 commits into from
Sep 20, 2023

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Sep 13, 2023 •
edited
Loading

Fixes:

  • Site navigation CSS issues
  • Duplicate posts in /latest
  • Homepage not using atom-excerpt and atom-title
  • Article header @ mobile
  • Lightbox zoom-in cursor

Before / Afters

sm alignment before after
md nav wrapping before after
nav wrapping before after
article header before after

@ikesau ikesau requested a review from mlbrgl September 13, 2023 22:03
mlbrgl
mlbrgl approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@mlbrgl mlbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't followed the design discussion around the header very closely but the implementation looks sensible to me.

@mlbrgl
Copy link
Member

mlbrgl commented Sep 20, 2023

And thanks for the before/after screenshots, that very helpful 👍

@ikesau ikesau merged commit a0a4cbb into master Sep 20, 2023
@ikesau ikesau deleted the misc-touchups branch September 20, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlbrgl mlbrgl mlbrgl approved these changes

Assignees

@ikesau ikesau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesau @mlbrgl