Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grapher redesign: Move single data column closer to the entity column #2623

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

sophiamersmann
Copy link
Member

Moves the data column closer to the entity column for tables that have a single data column only, see Figma for a design.

  • This is done by setting a minimum width on the column, and a maximum width on the content within that column
  • To find an appropriate maximum width, I need to know the width of the content (if the maximum width is smaller than the content, then the values wouldn't be aligned on the right)
  • Instead of measuring the width of all displayed data values, I only measure the width of the minimum and the maximum value

I'd prefer a css-only solution but I couldn't think of one. @samizdatco feel free to edit/merge/close as you please.

@sophiamersmann sophiamersmann mentioned this pull request Sep 7, 2023
17 tasks
@github-actions
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Sep 22, 2023
@github-actions github-actions bot closed this Sep 25, 2023
@marcelgerber marcelgerber reopened this Sep 25, 2023
@sophiamersmann sophiamersmann force-pushed the fix-grapher-redesign-enhance-table branch from 9089810 to a5a403b Compare September 25, 2023 14:45
@github-actions github-actions bot removed the stale label Sep 26, 2023
@sophiamersmann sophiamersmann force-pushed the fix-grapher-redesign-enhance-table branch from a5a403b to 645520d Compare September 26, 2023 09:21
@sophiamersmann
Copy link
Member Author

Merging this now for lack of time for finding a better solution

@sophiamersmann sophiamersmann removed the request for review from samizdatco September 26, 2023 09:30
@sophiamersmann sophiamersmann merged commit 52153be into grapher-redesign Sep 26, 2023
7 of 10 checks passed
@sophiamersmann sophiamersmann deleted the fix-grapher-redesign-enhance-table branch September 26, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants