Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include featured image in wpPost -> ArchieML migration #2278

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jun 1, 2023

We didn't have all the other plumbing for featured images set up when this migration script was written. I'm trying to add it in now.

@ikesau ikesau requested a review from danyx23 June 1, 2023 21:30
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I assume you have tried running the migrate script and it looks good? I haven't done that but if you have then this can be merged.

After you merge this don't forget to run the script on prod so we get the thumbnails migrated :)

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Aug 2, 2023
@ikesau ikesau force-pushed the gdocs-touchups-v2 branch from 65bcf25 to f06fea6 Compare August 2, 2023 14:09
@github-actions github-actions bot removed the stale label Aug 3, 2023
@github-actions
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Aug 18, 2023
@github-actions github-actions bot closed this Aug 21, 2023
@danyx23
Copy link
Contributor

danyx23 commented Oct 2, 2023

@ikesau was this work merged some other way or was this lost?

@ikesau
Copy link
Member Author

ikesau commented Oct 2, 2023

Looks like it didn't make it! 🤔 🙈

Let me test it out again and merge if all's well

@ikesau ikesau reopened this Oct 2, 2023
@github-actions github-actions bot removed the stale label Oct 3, 2023
@github-actions
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Oct 17, 2023
@ikesau
Copy link
Member Author

ikesau commented Oct 18, 2023

I've tested this and it's not working correctly. Will try to fix it soon :)

@ikesau ikesau removed the stale label Oct 18, 2023
@danyx23
Copy link
Contributor

danyx23 commented Oct 18, 2023

@ikesau let me know if you need help on this or want to push this over to my side - I will need this soon for the work on the automated "related research and writing" block for data pages - see #2736

@danyx23
Copy link
Contributor

danyx23 commented Oct 25, 2023

@ikesau how should we proceed with this one? Could you have a look some time soon or should I try to take this over?

@ikesau ikesau force-pushed the gdocs-touchups-v2 branch from f06fea6 to 05e4bed Compare October 25, 2023 19:57
@ikesau ikesau marked this pull request as ready for review October 25, 2023 20:00
@ikesau
Copy link
Member Author

ikesau commented Oct 25, 2023

@danyx23 working! 👍

To get these images in archie as part of the migrateWpPostsToArchieMl job, it requires the posts table featured_image column to be populated, which this PR does via the syncPostToGrapher function.

There's no mechanism to run this job on every entry in the posts table, as I'm not aware of any system we have to run a wpdb-dependent migration.

Thus I think some small manual script to re-run syncPostToGrapher on each post might be the way to go? What do you think?

@ikesau
Copy link
Member Author

ikesau commented Oct 26, 2023

@danyx23 Code added to syncPostsToGrapher. Maybe just test it on your local too and then we can merge 🙂

@danyx23 danyx23 self-requested a review October 31, 2023 08:02
@danyx23 danyx23 merged commit c33b656 into master Oct 31, 2023
13 checks passed
@danyx23 danyx23 deleted the gdocs-touchups-v2 branch October 31, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants