-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include featured image in wpPost -> ArchieML migration #2278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I assume you have tried running the migrate script and it looks good? I haven't done that but if you have then this can be merged.
After you merge this don't forget to run the script on prod so we get the thumbnails migrated :)
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
65bcf25
to
f06fea6
Compare
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
@ikesau was this work merged some other way or was this lost? |
Looks like it didn't make it! 🤔 🙈 Let me test it out again and merge if all's well |
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
I've tested this and it's not working correctly. Will try to fix it soon :) |
@ikesau how should we proceed with this one? Could you have a look some time soon or should I try to take this over? |
f06fea6
to
05e4bed
Compare
@danyx23 working! 👍 To get these images in archie as part of the There's no mechanism to run this job on every entry in the Thus I think some small manual script to re-run |
@danyx23 Code added to syncPostsToGrapher. Maybe just test it on your local too and then we can merge 🙂 |
We didn't have all the other plumbing for featured images set up when this migration script was written. I'm trying to add it in now.