Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept: types in grapher data model #1692

Closed
larsyencken opened this issue Oct 4, 2022 · 2 comments · Fixed by #3375
Closed

Concept: types in grapher data model #1692

larsyencken opened this issue Oct 4, 2022 · 2 comments · Fixed by #3375

Comments

@larsyencken
Copy link
Contributor

Problem

  • The data processing in Grapher on the client is more complex than it needs to be because we don't know types
  • Visualisation is more complex than it needs to be because we don't know types
    • E.g. we don't know hierarchy between categorical variables (World vs Europe vs Sweden)
    • E.g. we don't know that a categorical variable is in fact ordinal (Low Income, Middle Income, Upper Income)
    • E.g. we can't auto-pick the best color palette because we don't know enough about the categorical variable

Proposed solution

  • Add a type system to Grapher's data model that includes numeric, geo, and ordinal types (with optional ordering)
@larsyencken
Copy link
Contributor Author

@pabloarosado Just a head up from the ETL side that this is something that we'd like to move towards.

@sophiamersmann
Copy link
Member

sophiamersmann commented Jan 12, 2024

See #3376 for a list of things that we could improve if we knew data types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants