🔨 fix a subtle bug that opened the wrong covid explorer view in redir…

…ects
owid · Dec 6, 2023 · f44f668 · f44f668
1 parent 906129a
commit f44f668
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/explorer/urlMigrations/LegacyCovidUrlMigration.ts b/explorer/urlMigrations/LegacyCovidUrlMigration.ts
@@ -57,7 +57,7 @@ const covidIntervalFromLegacyQueryParams = (queryParams: QueryParams) => {
 }
 
 const boolParamToString = (bool: boolean | string | undefined) =>
-    bool ? "true" : "false"
+    bool === "true" || bool === "false" ? bool : bool ? "true" : "false"
 
 const legacyToCurrentCovidQueryParams = (
     queryParams: QueryParams,
@@ -101,16 +101,16 @@ const legacyToCurrentCovidQueryParams = (
         "Align outbreaks": boolParamToString(
             queryParams["Align outbreaks"] ??
                 baseQueryParams["Align outbreaks"] ??
-                urlContainsMetric
-                ? queryParams.aligned
-                : baseQueryParams.aligned
+                (urlContainsMetric
+                    ? queryParams.aligned
+                    : baseQueryParams.aligned)
         ),
         "Relative to Population": boolParamToString(
             queryParams["Relative to Population"] ??
                 baseQueryParams["Relative to Population"] ??
-                urlContainsMetric
-                ? queryParams.perCapita
-                : baseQueryParams.perCapita
+                (urlContainsMetric
+                    ? queryParams.perCapita
+                    : baseQueryParams.perCapita)
         ),
     }