🎉 (grapher) make charts inherit indicator-level settings

owid · Jul 18, 2024 · de54456 · de54456
1 parent c878cdd
commit de54456
Show file tree

Hide file tree

Showing 11 changed files with 671 additions and 189 deletions.
diff --git a/adminSiteClient/AdminApp.tsx b/adminSiteClient/AdminApp.tsx
@@ -154,6 +154,17 @@ export class AdminApp extends React.Component<{
                                 path="/charts"
                                 component={ChartIndexPage}
                             />
+                            {/* TODO(inheritance) */}
+                            {/* <Route
+                                exact
+                                path="/indicator-charts/create"
+                                component={ChartEditorPage}
+                            />
+                            <Route
+                                exact
+                                path="/indicator-charts/:indicatorId/edit"
+                                component={ChartEditorPage}
+                            /> */}
                             <Route
                                 exact
                                 path={`/${EXPLORERS_ROUTE_FOLDER}/:slug`}

diff --git a/adminSiteClient/ChartEditorPage.tsx b/adminSiteClient/ChartEditorPage.tsx
@@ -187,6 +187,19 @@ export class ChartEditorPage
                 datasets: groupedByNamespace[namespace] as Dataset[],
             })
         }
+
+        const usageData = (await this.context.admin.getJSON(
+            `/api/variables.usages.json`
+        )) as {
+            variableId: number
+            usageCount: number
+        }[]
+        this.database.variableUsageCounts = new Map(
+            usageData.map(({ variableId, usageCount }) => [
+                variableId,
+                +usageCount,
+            ])
+        )
     }
 
     async fetchLogs(): Promise<void> {