Merge pull request #3327 from owid/homepage-small-fixes

fix(homepage): url-encode tag name for icon
owid · Mar 11, 2024 · de07974 · de07974
2 parents 7788e9e + 9b26564
commit de07974
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/site/gdocs/components/ExplorerTiles.tsx b/site/gdocs/components/ExplorerTiles.tsx
@@ -18,8 +18,12 @@ function ExplorerTile({ url }: { url: string }) {
         <img
             height={40}
             width={40}
-            src={`${BAKED_BASE_URL}/images/tag-icons/${linkedChart.tags[0].name}.svg`}
+            src={`${BAKED_BASE_URL}/images/tag-icons/${encodeURIComponent(
+                linkedChart.tags[0].name
+            )}.svg`}
             className="explorer-tile__icon"
+            alt={`Icon for topic ${linkedChart.tags[0].name}`}
+            loading="lazy"
         />
     ) : null
 

diff --git a/site/gdocs/components/HomepageIntro.tsx b/site/gdocs/components/HomepageIntro.tsx
@@ -165,6 +165,7 @@ export function HomepageIntro({ className, featuredWork }: HomepageIntroProps) {
                     alt="Logos of the publications that have used our content. From left to right: Science, Nature, PNAS, BBC, Financial Times, The New York Times, The Guardian, The Atlantic, and The Washington Post"
                     width={230}
                     height={75}
+                    loading="lazy"
                 />
             </section>
             <section className="grid grid-cols-9 span-cols-9 col-start-5 span-md-cols-12 col-md-start-2 homepage-intro__right-section">