refactor: use map instead of for-loop

owid · Sep 26, 2023 · d8a592a · d8a592a
1 parent 18521e6
commit d8a592a
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/baker/algolia/indexExplorersToAlgolia.ts b/baker/algolia/indexExplorersToAlgolia.ts
@@ -157,21 +157,15 @@ const getExplorerRecords = async (): Promise<ExplorerRecord[]> => {
                 const textChunksForIteration = textChunks.length
                     ? textChunks
                     : [""]
-                const explorerRecords = []
-                let i = 0
-                for (const chunk of textChunksForIteration) {
-                    explorerRecords.push({
-                        slug,
-                        title: getNullishJSONValueAsPlaintext(title),
-                        subtitle: getNullishJSONValueAsPlaintext(subtitle),
-                        views_7d:
-                            pageviews[`/explorers/${slug}`]?.views_7d || 0,
-                        text: chunk,
-                        objectID: `${slug}-${i}`,
-                    })
-                    i++
-                }
-                return explorerRecords
+
+                return textChunksForIteration.map((chunk, i) => ({
+                    slug,
+                    title: getNullishJSONValueAsPlaintext(title),
+                    subtitle: getNullishJSONValueAsPlaintext(subtitle),
+                    views_7d: pageviews[`/explorers/${slug}`]?.views_7d ?? 0,
+                    text: chunk,
+                    objectID: `${slug}-${i}`,
+                }))
             })
         )