Skip to content

Commit

Permalink
enhance(entities): better handle scatter/marimekko/slope charts
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelgerber committed Mar 28, 2024
1 parent 81421a9 commit ba45b57
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion baker/updateChartEntities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ const obtainAvailableEntitiesForGrapherConfig = async (
const canChangeEntities =
grapher.canChangeEntity || grapher.canSelectMultipleEntities

if (canChangeEntities)
// In these chart types, an unselected entity is still shown
const chartTypeShowsUnselectedEntities =
grapher.isScatter || grapher.isSlopeChart || grapher.isMarimekko

if (canChangeEntities || chartTypeShowsUnselectedEntities)
return grapher.tableForSelection.availableEntityNames as string[]
else return grapher.selectedEntityNames
} else if (grapher.hasMapTab) {
Expand Down

0 comments on commit ba45b57

Please sign in to comment.