🐛 fix global entity selector

owid · Sep 17, 2024 · afb5731 · afb5731
1 parent d86af64
commit afb5731
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -65,6 +65,7 @@ import {
     getOriginAttributionFragments,
     sortBy,
     extractDetailsFromSyntax,
+    omit,
 } from "@ourworldindata/utils"
 import {
     MarkdownTextWrap,
@@ -505,7 +506,14 @@ export class Grapher
 
         if (props) this.setAuthoredVersion(props)
 
-        this.updateFromObject(props)
+        // prefer the manager's selection over the config's selectedEntityNames
+        // if both are passed in and the manager's selection is not empty.
+        // this is necessary for the global entity selector to work correctly.
+        if (props.manager?.selection?.hasSelection) {
+            this.updateFromObject(omit(props, "selectedEntityNames"))
+        } else {
+            this.updateFromObject(props)
+        }
 
         if (!props.table) this.downloadData()