🔨 post-rebase code cleanup

adminSiteServer/mockSiteRouter.ts

@@ -553,7 +553,7 @@ async function getTombstoneAttachments(
     }
 }
 
-getPlainRouteNonIdempotentWithRWTransaction(
+getPlainRouteWithROTransaction(
     mockSiteRouter,
     "/deleted/:tombstoneSlug",
     async (req, res, trx) => {

db/db.ts

@@ -812,20 +812,20 @@ export function getImageUsage(trx: KnexReadonlyTransaction): Promise<
 export async function generateTopicTagGraph(
     knex: KnexReadonlyTransaction
 ): Promise<TagGraphRoot> {
-    const { __rootId: rootId, ...parents } = await getFlatTagGraph(knex)
+    const { __rootId, ...parents } = await getFlatTagGraph(knex)
 
     const tagGraphTopicsOnly = Object.entries(parents).reduce(
         (acc: FlatTagGraph, [parentId, children]) => {
             acc[Number(parentId)] = children.filter((child) => {
-                if (child.parentId === rootId) return true
+                if (child.parentId === __rootId) return true
                 return child.isTopic
             })
             return acc
         },
         {} as FlatTagGraph
     )
 
-    return createTagGraph(tagGraphTopicsOnly, rootId)
+    return createTagGraph(tagGraphTopicsOnly, __rootId)
 }
 
 export const getUniqueTopicCount = (

db/model/Post.ts

@@ -183,8 +183,7 @@ export const getFullPostByIdFromSnapshot = async (
     return getFullPost(trx, postEnriched.wpApiSnapshot)
 }
 
-// kicking this can till WP posts kick the bucket
-// COVID pages are the only WP pages left that are citable, grep "pageOverrides" to see more
+// This function used to be more complicated, but now the only citable WP post is the COVID page
 export const isPostSlugCitable = (slug: string): boolean => {
     return slug === "coronavirus"
 }

site/runSiteNavigation.tsx

@@ -6,6 +6,7 @@ export const runSiteNavigation = (
     baseUrl: string,
     hideDonationFlag?: boolean
 ) => {
+    // Used to determine whether or not to show the searchbar in the header
     let isOnHomepage = false
     if (window._OWID_GDOC_PROPS) {
         const props = getOwidGdocFromJSON(window._OWID_GDOC_PROPS)