Merge pull request #3413 from owid/fix-gdocs-link-select

🐛 fix link type clause being optional
owid · Mar 26, 2024 · 753d99a · 753d99a
2 parents 63b9627 + 670ae73
commit 753d99a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/db/model/Link.ts b/db/model/Link.ts
@@ -14,6 +14,8 @@ export async function getPublishedLinksTo(
     ids: string[],
     linkType?: OwidGdocLinkType
 ): Promise<(DbPlainPostGdocLink & { sourceSlug: string })[]> {
+    const linkTypeClause = linkType ? "AND linkType = ?" : ""
+    const params = linkType ? [ids, linkType] : [ids]
     const rows = await knexRaw<DbPlainPostGdocLink & { sourceSlug: string }>(
         knex,
         `-- sql
@@ -25,10 +27,10 @@ export async function getPublishedLinksTo(
             JOIN posts_gdocs ON posts_gdocs_links.source = posts_gdocs.id
         WHERE
             target IN (?)
-            AND linkType = ?
+            ${linkTypeClause}
             AND published = TRUE
     `,
-        [ids, linkType]
+        params
     )
     return rows
 }