Merge pull request #3854 from owid/smarter-grapher-admin-boolean

🔨 more specific check for `Grapher.useAdminAPI`
owid · Aug 6, 2024 · 70e5f8d · 70e5f8d
2 parents c24a48d + 47cb9b5
commit 70e5f8d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -858,7 +858,11 @@ export class Grapher
      */
     @computed get useAdminAPI(): boolean {
         if (typeof window === "undefined") return false
-        return window.admin !== undefined
+        return (
+            window.admin !== undefined &&
+            // Ensure that we're not accidentally matching on a DOM element with an ID of "admin"
+            typeof window.admin.isSuperuser === "boolean"
+        )
     }
 
     @computed get isUserLoggedInAsAdmin(): boolean {