enhance: narrative views are reflected as links in gdocs

owid · Dec 17, 2024 · 6d74882 · 6d74882
1 parent d71f175
commit 6d74882
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/db/model/Gdoc/GdocBase.ts b/db/model/Gdoc/GdocBase.ts
@@ -48,7 +48,7 @@ import {
     getVariableMetadata,
     getVariableOfDatapageIfApplicable,
 } from "../Variable.js"
-import { createLinkFromUrl } from "../Link.js"
+import { createLinkForNarrativeChart, createLinkFromUrl } from "../Link.js"
 import {
     getMultiDimDataPageBySlug,
     isMultiDimDataPagePublished,
@@ -330,6 +330,13 @@ export class GdocBase implements OwidGdocBaseInterface {
                     componentType: block.type,
                 }),
             ])
+            .with({ type: "narrative-chart" }, (block) => [
+                createLinkForNarrativeChart({
+                    name: block.name,
+                    source: this,
+                    componentType: block.type,
+                }),
+            ])
             .with({ type: "all-charts" }, (block) =>
                 block.top.map((item) =>
                     createLinkFromUrl({
@@ -559,10 +566,6 @@ export class GdocBase implements OwidGdocBaseInterface {
                         "key-indicator-collection",
                         "list",
                         "missing-data",
-
-                        // Open question: there's not a direct link to a chart here, but there is a chart and also a parent chart
-                        "narrative-chart",
-
                         "numbered-list",
                         "people",
                         "people-rows",

diff --git a/db/model/Link.ts b/db/model/Link.ts
@@ -62,3 +62,23 @@ export function createLinkFromUrl({
         sourceId: source.id,
     } satisfies DbInsertPostGdocLink
 }
+
+export function createLinkForNarrativeChart({
+    name,
+    source,
+    componentType,
+}: {
+    name: string
+    source: GdocBase
+    componentType: string
+}): DbInsertPostGdocLink {
+    return {
+        target: name,
+        linkType: OwidGdocLinkType.NarrativeChart,
+        queryString: "",
+        hash: "",
+        text: "",
+        componentType,
+        sourceId: source.id,
+    } satisfies DbInsertPostGdocLink
+}
diff --git a/packages/@ourworldindata/types/src/gdocTypes/Gdoc.ts b/packages/@ourworldindata/types/src/gdocTypes/Gdoc.ts
@@ -281,6 +281,7 @@ export enum OwidGdocLinkType {
     Url = "url",
     Grapher = "grapher",
     Explorer = "explorer",
+    NarrativeChart = "narrative-chart",
 }
 
 export interface OwidGdocLinkJSON {