enhance(gdocs): validate narrative chart components

owid · Jan 27, 2025 · 5b90d2c · 5b90d2c
1 parent b642da5
commit 5b90d2c
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/db/model/Gdoc/GdocBase.ts b/db/model/Gdoc/GdocBase.ts
@@ -803,6 +803,9 @@ export class GdocBase implements OwidGdocBaseInterface {
         const chartIdsBySlug = await mapSlugsToIds(knex)
         const publishedExplorersBySlug =
             await db.getPublishedExplorersBySlug(knex)
+        const chartViewNames = await getChartViewsInfo(knex)
+            .then((cv) => cv.map((c) => c.name))
+            .then((chartViewNames) => new Set(chartViewNames))
 
         const linkErrors: OwidGdocErrorMessage[] = []
         for (const link of this.links) {
@@ -847,6 +850,16 @@ export class GdocBase implements OwidGdocBaseInterface {
                     }
                     break
                 }
+                case OwidGdocLinkType.ChartView: {
+                    if (!chartViewNames.has(link.target)) {
+                        linkErrors.push({
+                            property: "content",
+                            message: `Narrative chart with name ${link.target} does not exist`,
+                            type: OwidGdocErrorMessageType.Error,
+                        })
+                    }
+                    break
+                }
             }
         }