fix(settings): remove event listener with capture option, also

see MDN: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener#matching_event_listeners_for_removal
owid · Mar 22, 2024 · 4d21bc3 · 4d21bc3
1 parent 57767df
commit 4d21bc3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/@ourworldindata/grapher/src/controls/SettingsMenu.tsx b/packages/@ourworldindata/grapher/src/controls/SettingsMenu.tsx
@@ -225,7 +225,9 @@ export class SettingsMenu extends React.Component<{
 
     componentWillUnmount(): void {
         document.removeEventListener("keydown", this.onDocumentKeyDown)
-        document.removeEventListener("click", this.onDocumentClick)
+        document.removeEventListener("click", this.onDocumentClick, {
+            capture: true,
+        })
     }
 
     @action.bound onDocumentKeyDown(e: KeyboardEvent): void {