✨ code review enhancements for algolia indexing on publish

owid · Apr 9, 2024 · 3854a91 · 3854a91
1 parent 0fbe3b2
commit 3854a91
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/adminSiteClient/gdocsDeploy.ts b/adminSiteClient/gdocsDeploy.ts
@@ -188,7 +188,7 @@ export enum GdocPublishingAction {
     Updating = "Updating",
     Publishing = "Publishing",
     Unpublishing = "Unpublishing",
-    Saving = "Saving",
+    SavingDraft = "SavingDraft",
 }
 
 export function getPublishingAction(
@@ -199,6 +199,6 @@ export function getPublishingAction(
         .with([true, true], () => GdocPublishingAction.Updating)
         .with([false, true], () => GdocPublishingAction.Publishing)
         .with([true, false], () => GdocPublishingAction.Unpublishing)
-        .with([false, false], () => GdocPublishingAction.Saving)
+        .with([false, false], () => GdocPublishingAction.SavingDraft)
         .exhaustive()
 }
diff --git a/adminSiteServer/apiRouter.ts b/adminSiteServer/apiRouter.ts
@@ -2295,7 +2295,7 @@ getRouteNonIdempotentWithRWTransaction(
 
 /**
  * Handles all four `GdocPublishingAction` cases
- * - Saving (no action)
+ * - SavingDraft (no action)
  * - Publishing (index and bake)
  * - Updating (index and bake (potentially via lightning deploy))
  * - Unpublishing (remove from index and bake)
@@ -2313,7 +2313,7 @@ async function indexAndBakeGdocIfNeccesary(
     const isGdocPost = checkIsGdocPostExcludingFragments(nextJson)
 
     await match(action)
-        .with(GdocPublishingAction.Saving, lodash.noop)
+        .with(GdocPublishingAction.SavingDraft, lodash.noop)
         .with(GdocPublishingAction.Publishing, async () => {
             if (isGdocPost) {
                 await indexIndividualGdocPost(nextJson, trx, prevGdoc.slug)

diff --git a/baker/algolia/algoliaUtils.tsx b/baker/algolia/algoliaUtils.tsx
@@ -288,7 +288,7 @@ export async function indexIndividualGdocPost(
     const records = generateGdocRecords([gdoc], pageviewsForGdoc)
 
     const existingRecordsForPost: ObjectWithObjectID[] =
-        await getExistingRecordsForSlug(index, gdoc.slug)
+        await getExistingRecordsForSlug(index, indexedSlug)
 
     try {
         console.log("Updating Algolia index for Gdoc post", gdoc.slug)