refactor: use native findLast(Index) over lodash's

owid · Aug 8, 2024 · 34a9d94 · 34a9d94
1 parent 780165d
commit 34a9d94
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/adminSiteClient/GrapherConfigGridEditor.tsx b/adminSiteClient/GrapherConfigGridEditor.tsx
@@ -31,7 +31,6 @@ import { match, P } from "ts-pattern"
 //import * as lodash from "lodash"
 import {
     cloneDeep,
-    findLastIndex,
     isArray,
     isEmpty,
     isEqual,
@@ -1447,8 +1446,7 @@ export class GrapherConfigGridEditor extends React.Component<GrapherConfigGridEd
             (item) => item.key === itemKey
         )
         if (itemIndex !== -1) {
-            const lastVisibleIndex = findLastIndex(
-                columnSelection,
+            const lastVisibleIndex = columnSelection.findLastIndex(
                 (item) => item.visible
             )
 

diff --git a/packages/@ourworldindata/grapher/src/stackedCharts/StackedUtils.ts b/packages/@ourworldindata/grapher/src/stackedCharts/StackedUtils.ts
@@ -8,7 +8,6 @@ import {
     findGreatestCommonDivisorOfArray,
     rollingMap,
     omitUndefinedValues,
-    findLast,
 } from "@ourworldindata/utils"
 import { StackedPointPositionType, StackedSeries } from "./StackedConstants"
 
@@ -42,8 +41,8 @@ export const stackSeriesInBothDirections = <
                 .map((s) => s.points[pointIndex])
             const pointBelowThisOne =
                 point.value < 0
-                    ? findLast(pointsBelowThisOne, (p) => p.value < 0)
-                    : findLast(pointsBelowThisOne, (p) => p.value >= 0)
+                    ? pointsBelowThisOne.findLast((p) => p.value < 0)
+                    : pointsBelowThisOne.findLast((p) => p.value >= 0)
             point.valueOffset = pointBelowThisOne
                 ? pointBelowThisOne.value + pointBelowThisOne.valueOffset
                 : 0

diff --git a/packages/@ourworldindata/utils/src/Util.ts b/packages/@ourworldindata/utils/src/Util.ts
@@ -13,8 +13,6 @@ import {
     dropWhile,
     escapeRegExp,
     extend,
-    findLast,
-    findLastIndex,
     flatten,
     get,
     groupBy,
@@ -87,8 +85,6 @@ export {
     dropWhile,
     escapeRegExp,
     extend,
-    findLast,
-    findLastIndex,
     flatten,
     get,
     groupBy,

diff --git a/packages/@ourworldindata/utils/src/index.ts b/packages/@ourworldindata/utils/src/index.ts
@@ -156,8 +156,6 @@ export {
     dropRightWhile,
     dropWhile,
     extend,
-    findLast,
-    findLastIndex,
     flatten,
     get,
     groupBy,