refactor(table): pull out type definition

owid · Apr 27, 2024 · 301773e · 301773e
1 parent 3f81566
commit 301773e
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/packages/@ourworldindata/core-table/src/CoreTable.ts b/packages/@ourworldindata/core-table/src/CoreTable.ts
@@ -219,10 +219,13 @@ export class CoreTable<
         // Otherwise, operations like `.concat()` will break in unexpected ways.
         // See https://github.com/mobxjs/mobx/blob/mobx4and5/docs/best/pitfalls.md
         // Also, see https://github.com/owid/owid-grapher/issues/2948 for an issue caused by this problem.
+        type CoreValueArrayThatMayBeMobxProxy = CoreValueType[] & {
+            toJS?: () => CoreValueType[]
+        }
+
         for (const [slug, values] of Object.entries(columnStore)) {
-            const valuesThatMayBeMobxProxy = values as CoreValueType[] & {
-                toJS?: () => CoreValueType[]
-            }
+            const valuesThatMayBeMobxProxy =
+                values as CoreValueArrayThatMayBeMobxProxy
             if (typeof valuesThatMayBeMobxProxy.toJS === "function") {
                 columnStore[slug] = valuesThatMayBeMobxProxy.toJS()
             }