Skip to content

Commit

Permalink
Revert "Fix too many files generated for CF pages (#3818)" (#3833)
Browse files Browse the repository at this point in the history
This reverts commit 2670459.
  • Loading branch information
rakyi authored Aug 1, 2024
1 parent 2b79d4b commit 1fd373a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/@ourworldindata/utils/src/image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { traverseEnrichedBlock } from "./Util.js"
import { OwidGdoc, OwidGdocType, ImageMetadata } from "@ourworldindata/types"
import { match, P } from "ts-pattern"

export const AUTHOR_BYLINE_WIDTH = 48
export const THUMBNAIL_WIDTH = 100
export const LARGE_THUMBNAIL_WIDTH = 350

Expand All @@ -14,7 +15,7 @@ export function getSizes(
): number[] {
if (!originalWidth) return []
// ensure a thumbnail and author byline is generated
const widths = [THUMBNAIL_WIDTH]
const widths = [AUTHOR_BYLINE_WIDTH, THUMBNAIL_WIDTH]
// start at large thumbnail and go up by 500 to a max of 1350 before we just show the original image
let width = LARGE_THUMBNAIL_WIDTH
while (width < originalWidth && width <= 1350) {
Expand Down
2 changes: 1 addition & 1 deletion site/gdocs/components/Image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const containerSizes: Record<ImageParentContainer, string> = {
["datapage"]: gridSpan6,
["full-width"]: "100vw",
["key-insight"]: gridSpan5,
["author-byline"]: "100px",
["author-byline"]: "48px",
["author-header"]: gridSpan2,
["span-5"]: gridSpan5,
["span-6"]: gridSpan6,
Expand Down

0 comments on commit 1fd373a

Please sign in to comment.