Merge pull request #3421 from owid:fix-gdoc-tagging-bug

🐛 fix gdoc tagging bug
owid · Mar 28, 2024 · 1c8abdf · 1c8abdf
2 parents 7eb7ccc + 0cd669f
commit 1c8abdf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/adminSiteServer/apiRouter.ts b/adminSiteServer/apiRouter.ts
@@ -2416,14 +2416,11 @@ postRouteWithRWTransaction(
     async (req, res, trx) => {
         const { gdocId } = req.params
         const { tagIds } = req.body
+        const tagIdsAsObjects: { id: number }[] = tagIds.map((id: number) => ({
+            id: id,
+        }))
 
-        await setTagsForGdoc(
-            trx,
-            gdocId,
-            tagIds.map((id: number) => {
-                id
-            })
-        )
+        await setTagsForGdoc(trx, gdocId, tagIdsAsObjects)
 
         return { success: true }
     }

diff --git a/db/model/Gdoc/GdocFactory.ts b/db/model/Gdoc/GdocFactory.ts
@@ -492,10 +492,11 @@ export async function setTagsForGdoc(
     tagIds: Pick<DbPlainTag, "id">[]
 ): Promise<void> {
     await knex.table(PostsGdocsXTagsTableName).where({ gdocId }).delete()
-    if (tagIds.length)
+    const tagIdsForInsert = tagIds.map(({ id: tagId }) => ({ gdocId, tagId }))
+    if (tagIdsForInsert.length)
         await knex
             .table(PostsGdocsXTagsTableName)
-            .insert(tagIds.map(({ id: tagId }) => ({ gdocId, tagId })))
+            .insert(tagIdsForInsert)
 }
 
 export enum GdocLinkUpdateMode {