✨ explorer-tiles code review fixes

owid · Feb 15, 2024 · 08806e7 · 08806e7
1 parent 38875ca
commit 08806e7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/db/db.ts b/db/db.ts
@@ -185,8 +185,8 @@ export const getPublishedExplorersBySlug = async (
         `-- sql
         SELECT
             slug,
-            JSON_UNQUOTE(JSON_EXTRACT(config, "$.explorerTitle")) as title,
-            JSON_UNQUOTE(JSON_EXTRACT(config, "$.explorerSubtitle")) as subtitle
+            config->>"$.explorerTitle" as title,
+            config->>"$.explorerSubtitle" as subtitle
         FROM
             explorers
         WHERE

diff --git a/db/model/Gdoc/GdocBase.ts b/db/model/Gdoc/GdocBase.ts
@@ -578,7 +578,7 @@ export class GdocBase extends BaseEntity implements OwidGdocBaseInterface {
         )
 
         const linkedExplorerCharts = await Promise.all(
-            [...this.linkedChartSlugs.explorer.values()].map((originalSlug) => {
+            this.linkedChartSlugs.explorer.map((originalSlug) => {
                 const explorer = publishedExplorersBySlug[originalSlug]
                 if (!explorer) return
                 const linkedChart: LinkedChart = {

diff --git a/db/model/Gdoc/rawToEnriched.ts b/db/model/Gdoc/rawToEnriched.ts
@@ -1817,7 +1817,7 @@ function parseExplorerTiles(
     if (!raw.value.subtitle)
         return createError({ message: "Explorer tiles missing subtitle" })
 
-    if (!raw.value.explorers || !raw.value.explorers.length)
+    if (!raw.value.explorers?.length)
         return createError({ message: "Explorer tiles missing explorers" })
 
     const parsedExplorerUrls: { url: string }[] = []

diff --git a/public/explorer-thumbnail.webp b/public/explorer-thumbnail.webp
diff --git a/site/gdocs/components/ExplorerTiles.scss b/site/gdocs/components/ExplorerTiles.scss
@@ -43,7 +43,7 @@
         padding: 16px;
         display: flex;
         flex-wrap: wrap;
-        justify-content: space-between;
+        align-content: space-between;
     }
     .explorer-tile__icon {
         background-color: $blue-55;