Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

fix(extension): missing extension in downloaded file #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasrodes
Copy link
Member

Loading files from remote was not working because the temporary downloaded file to local was not saving the file with the appropriate extension. As a consequence, the proper loading pandas function was not being loaded.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #59 (890b070) into main (6cf53c7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   89.13%   89.15%   +0.02%     
==========================================
  Files          18       18              
  Lines         782      784       +2     
==========================================
+ Hits          697      699       +2     
  Misses         85       85              
Impacted Files Coverage Δ
owid/datautils/decorators.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucasrodes lucasrodes requested a review from pabloarosado May 11, 2023 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant