Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 wizard: dataset preview #3765

Merged
merged 19 commits into from
Dec 31, 2024
Merged

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Dec 24, 2024

I'm working on a preview of a dataset, which collapses all indicator-dimensions into single elements. In addition, this space can be a playground to test features to later incorporate into https://admin.owid.io/admin/datasets

Pending tasks:

  • Accept query-based search
  • Initialize indicator titles
  • Improve indicator-preview:
    • Show description
    • Show unit
    • Take inspiration from dataset page
  • Explore incorporating analytics?
  • Sort dimensions preview
  • Also preview non-dimensional indicators
  • Add chart
  • Add charts using indicator
  • Incorporate dataset-level metadata: isArchived, isPrivate, number of charts / indicators, etc.
    • Archived?
    • Private?
    • Number of indicators, number of charts
    • Date of last update
    • Date of creation
  • Add explorers using indicator
  • Improve search: Search by dataset title?
  • Improve error catching: If dataset is not in ETL, fail with informative message.
  • Add tags info
  • Add info on "chart last edits". Helps finding ownership.
  • show warning if dataset does not exist
  • Indicate if dataset has mdims
  • Add features from old "Dataset explorer"
  • Change primary color in app

Future Work:

  • Add options to filter, sort, etc. Might do later.
  • View by table?. Might do later
  • Experiment alternative UI: WON'T DO
    • Show indicators in collapsed expander. Problem: maybe it renders too slow? in that case drop dimension-container
    • Use initial indicator name in title.
    • Add tag (as with chart diff) signalling if indicator has dimensions.
  • Stress test it, look for edge cases where it fails. Will do after merge

/schedule

@owidbot
Copy link
Contributor

owidbot commented Dec 24, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-feature-collapsed-indicators

chart-diff: ✅ No charts for review.
data-diff: ❌ Found differences
= Dataset garden/who/2024-09-09/flu_test
  = Table flu_test
    ~ Dim country
-       - Removed values: 11 / 72774 (0.02%)
                date   country
          2024-12-16      Iran
          2024-12-23  Maldives
          2024-12-02 Sri Lanka
          2024-12-16  Tanzania
          2024-12-23   Tunisia
    ~ Dim date
-       - Removed values: 11 / 72774 (0.02%)
            country       date
               Iran 2024-12-16
           Maldives 2024-12-23
          Sri Lanka 2024-12-02
           Tanzania 2024-12-16
            Tunisia 2024-12-23
    ~ Column denomcombined (changed data)
-       - Removed values: 11 / 72774 (0.02%)
            country       date  denomcombined
               Iran 2024-12-16           4091
           Maldives 2024-12-23             17
          Sri Lanka 2024-12-02             34
           Tanzania 2024-12-16             29
            Tunisia 2024-12-23             76
        ~ Changed values: 2 / 72774 (0.00%)
             country       date  denomcombined -  denomcombined +
          Bangladesh 2024-12-02              399              240
          Bangladesh 2024-12-09              351              101
    ~ Column pcnt_poscombined (changed data)
-       - Removed values: 11 / 72774 (0.02%)
            country       date  pcnt_poscombined
               Iran 2024-12-16         21.461746
           Maldives 2024-12-23         11.764706
          Sri Lanka 2024-12-02         11.764706
           Tanzania 2024-12-16          3.448276
            Tunisia 2024-12-23          2.631579
        ~ Changed values: 2 / 72774 (0.00%)
             country       date  pcnt_poscombined -  pcnt_poscombined +
          Bangladesh 2024-12-02            1.503759            1.666667
          Bangladesh 2024-12-09            0.854701            2.970297


Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-12-31 11:24:18 UTC
Execution time: 16.85 seconds

@lucasrodes lucasrodes marked this pull request as ready for review December 31, 2024 01:50
@lucasrodes lucasrodes changed the title 🎉 list with collapsed indicators with dimensions 🎉 wizard: dataset preview Dec 31, 2024
Copy link

Merge Schedule
Scheduled to be merged the next time the merge action is scheduled via the cron expressions

@lucasrodes lucasrodes merged commit 547868b into master Dec 31, 2024
9 checks passed
@lucasrodes lucasrodes deleted the feature-collapsed-indicators-dimensions branch December 31, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants