Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 look for 'dead' code #3747

Merged
merged 12 commits into from
Dec 23, 2024
Merged

🔨 look for 'dead' code #3747

merged 12 commits into from
Dec 23, 2024

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Dec 20, 2024

Our codebase (etl/ and apps/) has grown in recent years. However, there are bits here and there that are not in use. This PR has a look at this and removes unnecessary code (functions, modules, etc.).

/schedule

@owidbot
Copy link
Contributor

owidbot commented Dec 20, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-refactor-dead-code-search

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-12-23 15:35:14 UTC
Execution time: 16.02 seconds

Copy link

Merge Schedule
Scheduled to be merged the next time the merge action is scheduled via the cron expressions

@lucasrodes lucasrodes marked this pull request as ready for review December 23, 2024 15:32
@lucasrodes lucasrodes merged commit 503f627 into master Dec 23, 2024
8 checks passed
@lucasrodes lucasrodes deleted the refactor-dead-code-search branch December 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants