-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 wizard: Create GIF/video from chart URL #3591
Conversation
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2024-11-26 11:02:30 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Pablo! Thanks for doing this, I'm interested in seeing where this brings us.
I agree that being able to export social-media ready charts would be a win, specially since I think these GIFs/animated content would be valuable in social media platforms.
As I've already mentioned you, I've renamed the app to something a bit more general in case we add support for non-gif exports too. That'd be very cool!
I've added some suggestions for changes that you can introduce to make this app a bit friendlier to the users.
Some other general comments:
- I recommend you take a look at method
st_horizontal
(inapps.wizard.utils
), which allows you to display streamlit widgets in one line. This can be helpful for steps 2/3, where there's lots of options that take lots of vertical space, IMO. You could squeeze them a bit. E.g. I think that one line for a small checkbox is suboptimal. - I think you can get rid of step 2. Most of its logic can just run after after submitting the char URL in step 1 (it's fast enough I think). Some of the other options can be in step 3 (eventually renamed as step 2).
Also, you may want to look at st.form which might be useful to group different widgets. Alternatively, maybe you can use st.container(border=True)
to visually group widgets.
Once again, thanks for your work!
Hi @lucasrodes thanks for all the inputs! In the end, I went all in and allowed conversion to mp4 as well (which requires a couple of extra libraries, but I think that's fine). Feel free to give it another try and please let me know if you have any other suggestions. |
Hey @pabloarosado! I've added a couple of cosmetic changes, including:
|
There is a minor bug. Recreate it as:
Nothing seems to happen then. Even after clicking 'animate'. The output remains as the original one, the map. Related to this bug, I think we should have some flow control for the 'animate' button. Now, whenever you click on something in the third container, it will just run and generate the output. I think we should wait for the user to click on 'animate' right? These are not major bugs, so fine to merge. But if you have time, good to look at. Once again, thanks for adding this! We should def add mobile export support somehow. |
I've always thought it would be convenient to have an easy way to generate GIFs/Videos from a chart. This PR creates:
NOTES:
Example use of CLI: