Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 harmonize: Fix harmonize ipython when used on already harmonized datasets #3577

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

pabloarosado
Copy link
Contributor

@pabloarosado pabloarosado commented Nov 20, 2024

Fixes #3559

I encountered the same issue and patched it quickly, I haven't looked thoroughly into it, but it worked for my case.

@owidbot
Copy link
Contributor

owidbot commented Nov 20, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-fix-harmonize-ipython

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-11-20 13:42:25 UTC
Execution time: 15.63 seconds

@lucasrodes
Copy link
Member

@antea04 when you have time, could you try it out and see if it solves the issue for you, too?

Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your changes make sense, @pabloarosado! Good catch.

This helped me understand what the issue was actually! I added this comment #3559 (comment) to the related issue clarifying a bit more the issue.

@pabloarosado
Copy link
Contributor Author

Thanks @lucasrodes, I'm not sure if the current behavior is what we'd want, but at least now harmonize_ipython can be used when all country names are already harmonized. We can revisit it later and tweak it again in a separate PR.

@pabloarosado pabloarosado merged commit 966a562 into master Nov 20, 2024
12 checks passed
@pabloarosado pabloarosado deleted the fix-harmonize-ipython branch November 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harmonize_ipython doesn't offer to export mapping of countries if no ambiguous countries are found
3 participants