Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📊 antibiotics: WHO Antibiotic usage #3535

Merged
merged 38 commits into from
Nov 19, 2024
Merged

📊 antibiotics: WHO Antibiotic usage #3535

merged 38 commits into from
Nov 19, 2024

Conversation

spoonerf
Copy link
Contributor

@spoonerf spoonerf commented Nov 13, 2024

Hey @Marigold, I'm running into a bit of Jinja issue that I can't figure out, would you be able to take a look to see if you can spot the issue.

Quite often with Jinja there's missing spaces around index terms e.g. for the routeofadministration term in the titles of variables in this dataset.

I've tried to add spaces in the metadata but still the titles look like this: Defined daily doses ofparentearally administeredAntivirals for systemic use (ATC J05) - antivirals for treatment of hiv infections, combinations (j05ar) used, with no spaces around 'parentearally administered'. Any idea what I'm missing?

@owidbot
Copy link
Contributor

owidbot commented Nov 13, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-who-amu

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
+ Dataset garden/antibiotics/2024-11-12/antimicrobial_usage
+ + Table aware
+   + Column ddd
+   + Column did
+ + Table class
+   + Column ddd
+   + Column did
+ Dataset garden/antibiotics/2024-11-15/testing_coverage
+ + Table testing_coverage
+   + Column ctas_with_reported_bcis_bloodstream
+   + Column ctas_with_reported_bcis_gonorrhea
+   + Column ctas_with_reported_bcis_stool
+   + Column ctas_with_reported_bcis_urine
+   + Column ctas_with_reported_bcis_with_ast__gt__80_bcis_bloodstream
+   + Column ctas_with_reported_bcis_with_ast__gt__80_bcis_gonorrhea
+   + Column ctas_with_reported_bcis_with_ast__gt__80_bcis_stool
+   + Column ctas_with_reported_bcis_with_ast__gt__80_bcis_urine
+   + Column total_bcis_bloodstream
+   + Column total_bcis_gonorrhea
+   + Column total_bcis_stool
+   + Column total_bcis_urine
+   + Column total_bcis_with_ast_bloodstream
+   + Column total_bcis_with_ast_gonorrhea
+   + Column total_bcis_with_ast_stool
+   + Column total_bcis_with_ast_urine


Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-11-19 12:30:41 UTC
Execution time: 4.06 seconds

@spoonerf spoonerf marked this pull request as ready for review November 15, 2024 15:00
@Marigold
Copy link
Collaborator

It was caused by the dash in <% if. <%- if trims all whitespaces before the block (or after if you use -%>). I've set reasonable defaults so that in most cases you never have to use - in ifs (which worked in this case). If you have to use them, they can quickly become very confusing...

@spoonerf
Copy link
Contributor Author

It was caused by the dash in <% if. <%- if trims all whitespaces before the block (or after if you use -%>). I've set reasonable defaults so that in most cases you never have to use - in ifs (which worked in this case). If you have to use them, they can quickly become very confusing...

Okay brilliant, thanks! I'll avoid '-' in the future!

@spoonerf spoonerf merged commit 3ac00fa into master Nov 19, 2024
8 checks passed
@spoonerf spoonerf deleted the who-amu branch November 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants