Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multidimension variable load #3520

Closed
wants to merge 9 commits into from

Conversation

pabloarosado
Copy link
Contributor

Loading variable data was failing on multidimensional indicators on this branch (more details on this issue).

@Marigold I have quickly brute-forced a solution, but I'm not sure if it does the intended effect. Please let me know if it doesn't make sense.

@pabloarosado pabloarosado requested a review from Marigold November 8, 2024 13:49
@pabloarosado pabloarosado self-assigned this Nov 8, 2024
@pabloarosado pabloarosado changed the base branch from master to global-mpi-2024 November 8, 2024 13:49
@owidbot
Copy link
Contributor

owidbot commented Nov 8, 2024

Quick links (staging server):

Site Admin Wizard Docs

Login: ssh owid@staging-site-fix-multidimension-variable-load

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
+ Dataset garden/ophi/2024-10-28/multidimensional_poverty_index
+ + Table multidimensional_poverty_index
+   + Column intensity
+   + Column headcount_ratio
+   + Column mpi
+   + Column uncensored_headcount_ratio
+   + Column censored_headcount_ratio
+   + Column severe
+   + Column vulnerable


Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-11-08 13:52:53 UTC
Execution time: 70.24 seconds

@pabloarosado pabloarosado marked this pull request as ready for review November 8, 2024 13:51
@Marigold
Copy link
Collaborator

Marigold commented Nov 8, 2024

@pabloarosado I have something similar plus some performance improvements in this PR. I'd merge my PR first (since it covers more edge cases found in GHE) and then double check that it works for MPI too.

@pabloarosado
Copy link
Contributor Author

@pabloarosado I have something similar plus some performance improvements in this PR. I'd merge my PR first (since it covers more edge cases found in GHE) and then double check that it works for MPI too.

Thanks! Feel free to close this PR if you have already a solution for that bug.

Base automatically changed from global-mpi-2024 to master November 8, 2024 16:52
@Marigold
Copy link
Collaborator

Fixed elsewhere.

@Marigold Marigold closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants