✨ Improve faostat metadata #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonerf
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we were not able to edit FAOSTAT metadata, and we were showing it (in the sources tab and data pages) raw, as it came from the data provider. It often produced very long, poorly formatted paragraphs, hard do understand, our sources tab and data pages.
Additionally, it wasn't possible (at least not easily) to edit those fields manually, because those texts were produced programmatically in the middle of a complicated processing pipeline.
This PR allows us to quickly fix, add or remove specific fields in the metadata. All FAOSTAT metadata is moved to either the snapshot description, or the
description_from_producer.This PR would also fix data pages like this one with very bad titles that were constructed from FAOSTAT names.
I have also gone through all indicators that are used in at least one chart, and added basic metadata to them. I haven't spent much time adding
description_shortanddescription_key, but at least now we have a way to easily add those, if needed.There is no need to review the code. A thorough review of all the metadata is also unnecessary. But I think it would be good to scroll through the
.meta.ymlfiles to inspect for some odd titles or descriptions quickly.