Skip to content

Commit

Permalink
🐛 Fix dataclasses-json error (#1798)
Browse files Browse the repository at this point in the history
* 🐛 pin dataclasses-json to avoid error in python3.9

* 🐝 bump owid-catalog version
  • Loading branch information
Marigold authored Oct 17, 2023
1 parent bc25997 commit 83a8a77
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 18 deletions.
2 changes: 2 additions & 0 deletions lib/catalog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ t = Table.read_csv('/tmp/my_table.csv')
## Changelog

- `dev`
- `v0.3.8`
- Pin dataclasses-json==0.5.8 to fix error with python3.9
- `v0.3.7`
- Fix bugs.
- Improve metadata propagation.
Expand Down
10 changes: 5 additions & 5 deletions lib/catalog/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions lib/catalog/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "owid-catalog"
version = "0.3.7"
version = "0.3.8"
description = "Core data types used by OWID for managing data."
authors = ["Our World in Data <[email protected]>"]
license = "MIT"
Expand All @@ -13,7 +13,6 @@ homepage = "https://github.com/owid/owid-grapher-py"
python = ">=3.8.1"
pandas = ">=1.3.3,<2.0"
jsonschema = ">=3.2.0"
dataclasses-json = ">=0.5.6"
pyarrow = ">=10.0.1"
ipdb = ">=0.13.9"
requests = ">=2.26.0"
Expand All @@ -24,6 +23,9 @@ structlog = ">=21.5.0"
owid-repack = ">=0.1.1"
dynamic-yaml = "^1.3.4"
mistune = "^3.0.1"
# higher version causes error in python 3.9 when running
# from owid import catalog; catalog.find("global_carbon_budget").sort_values("version", ascending=False).iloc[0].load()
dataclasses-json = "0.5.8"

[tool.poetry.group.dev.dependencies]
pytest = ">=6.2.5"
Expand All @@ -36,7 +38,6 @@ isort = ">=5.12.0"
# unpinning those would introduce tons of type errors
pyright = "1.1.288"
pandas-stubs = "1.2.0.62"
dataclasses-json = "0.5.7"


[tool.isort]
Expand Down
17 changes: 8 additions & 9 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ gspread = "^5.10.0"
# unpinning those would introduce tons of type errors
pyright = "1.1.288"
pandas-stubs = "1.2.0.62"
dataclasses-json = "0.5.7"
jsonref = "^1.1.0"
mkdocs-jupyter = "^0.24.2"
mkdocs-exclude = "^1.0.2"
Expand Down

0 comments on commit 83a8a77

Please sign in to comment.